Check for newsfragments #3055
Merged
Check for newsfragments #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A5rocks
force-pushed
the
check-newsfragments
branch
2 times, most recently
from
3433d34
to
3fb76a1
Compare
A5rocks
force-pushed
the
check-newsfragments
branch
from
3fb76a1
to
9ddc4b2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3055 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 120 120
Lines 17832 17832
Branches 3204 3204
=======================================
Hits 17767 17767
Misses 46 46
Partials 19 19
|
|
Why is on pull request trigger checking |
|
Copy-paste from the default types + labelled, but good point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3048
This is something way too easy to forget: hence, automation. I don't think the screening done here is great, but hopefully it's good enough for now?